ROX-Filer file copy error message

Aarf also reported an error message when he used ROX-Filer to copy a file. Others have also reported this problem, although the file does actually copy ok. This is a problem when filesare copied from a Linux filesystem to a msdos/vfat filesystem and it was not possible to maintain the same file attributes.

ROX really should not report this as a failure to copy the file. I am thinking of having a go at hacking ROX to not show this error message. Note that 4.1 is using ROX-Filer version '2.6.1-pup9'. If anyone more competent at hacking C code than me would like to tackle this, please do. The source code (not pristine 2.6.1, already hacked by Nathan), is to be found here:

http://puptrix.org/sources/alphabetical/r/

Note that in an early 4.1alpha I did try ROX 2.8, but sometimes it did not start when X started. So I rolled back to 2.6.1 as used in 4.00 and 3.01.

Posted on 17 Oct 2008, 8:44


Comments:

Posted on 17 Oct 2008, 9:09 by Lobster
Rox works
"Others have also reported this problem, although the file does actually copy ok."

I had this today, when copying files for a friend.I knew from experience that the files were copied
but . . . a new user would assume not copied

It is a serious and disconcerting bug.
I hope you can hack it :)




Posted on 17 Oct 2008, 17:02 by BarryK
Hacking ROX
I don't think I can get the time, plus I never feel comfortable hacking C code. Anyone like to volunteer? I know we have some very good C coders...



Posted on 17 Oct 2008, 21:11 by lluamco
No need to hack ROX
Hi Barry,

in ROX's faq http://roscidus.com/desktop/node/255

it is stated that "The 'quiet' mount option can be used in /etc/fstab to stop the message being displayed."

I have tried it and it works. Here it is the entry in my /etc/fstab

/dev/sdb1 /mnt/sdb1 vfat rw,quiet,dmask=0022,iocharset=iso8859-1 0 0

I'm sure you can easily add the 'quite'

option when mounting vfat and ntfs partitions.

Hope that helps


Posted on 17 Oct 2008, 22:00 by lluamco
quiet NOT quite
Sorry, I meant "I'm sure you can easily add the 'quiet' option...


Posted on 18 Oct 2008, 9:52 by Mike Lockmoore
What is the error message?
Barry, what is the specific error message (at least part of it I could do a text search on)? I'm good with C, but I've never looked through the ROX Filer source code, so I don't know exactly where to look at the code that is popping the message up.



Posted on 18 Oct 2008, 10:22 by BarryK
ROX fail msg
Error message:

Operation not permitted
Failed to copy '/root/untitled10'

Done
There was one error.


Then, only the Cancel button is active.

Hit Cancel button, but the file is still copied ok. The file attributes though have been changed from 644 to 755 (all execute flags set).



Posted on 18 Oct 2008, 11:48 by rarsa
I don't think it's a bug
This functionality is by design so users know that they are loosing the file attributes.

So technically is not a bug, Although the message is quite confusing as this should be a warning, not an error.


Posted on 19 Oct 2008, 14:10 by Mike Lockmoore
Porgress
I've done some experiments. I modified the code to check whether the copy exists in the destination directory. If it exists, the current error message is skipped. However, I tried to get the message to produce a warning message if the mode (permission bits) are different for the copy compared to the original. I can see the warning message if I add a sleep() call to pause the action box, but without it it blinks away so fast, the user will not get to see the warning.

What I'd like to use is a message box with just an OK button in it to warn the user about the permission bits being different... but the ROX-Filer action box is not quite right for this job. It has "Cancel" "Yes" "No" and "Quiet" buttons... none of which is really appropriate for a warning. Any suggestions?


Posted on 19 Oct 2008, 16:36 by BarryK
Skipped warning
I don't know anything about GTK programming, so cannot advise.

Wouldn't it be good enough to check that the file permission bits are different and if so just skip the error dialog window?

Would need to be careful that it doesn't get skipped if something is really wrong though, like the destination file smaller.

I know it would be nice to have the warning though.


Posted on 19 Oct 2008, 16:42 by BarryK
Quick hack
Mike,
I appreciate what you're doing. Probably just a basic hack to avoid the error msg if permission bits differ is good enough for the upcoming 4.1.1.

At least then, people won't think that the file didn't get copied/moved.


Posted on 19 Oct 2008, 17:38 by lluamco
mount -o quiet
The error message does not appear if mounting of vfat (and I presume ntfs) filesystems is handled with the "-o quiet" option. I have checked it (only for vfat) replacing every "mount -t vfat ..." by

"mount -t vfat - o quiet ..." (and similarly for ntfs )in the following files:

/usr/local/bin/drive_all

/usr/sbin/pmount

and replacing

"ntfs-3g $CMDPRMS -o umask=0,no_def_opts ..."

by

"ntfs-3g $CMDPRMS -o umask=0,no_def_opts,quiet ..."

and

"busybox moun busybox mount -r -t ntfs $CMDPRMSt -r -t ntfs $CMDPRMS"

by

"busybox mount -r -t ntfs -o quiet $CMDPRMS"

in file /bin/pmount




Posted on 20 Oct 2008, 8:10 by BarryK
Test reply
Test reply


Posted on 20 Oct 2008, 11:13 by Mike Lockmoore
ROX code fix
I posted a reply in your more recent blog post about changing the mount options as suggested by lluamco above. If you still would like a code fix for ROX, I can get it to you now.
--
Mike