ROX-Filer from git, Dec. 2010

Ttuuxxx posted that the latest ROX-Filer from git behaves itself very well:

http://bkhome.org/blog/?viewDetailed=01570

So, I have upgraded, using it in Wary seems good. This PET is available for all Woof builds, most builds will default to using it.

Yes, as ttuuxxx has observed, the focus problem has improved and drag-and-drop from SM works, however there is still one thing. We need to tell the Rox developers about this:

You can right-click and from the menu if you select "Open As Text" or "Properties" then great, the focus is released from the icon. However, if you select "Send To" (patched by me to "Open With") then focus is not released -- the icon remains highlighted. This is a bug.

Patched source:
http://bkhome.org/sources/alphabetical/r/rox-filer-201012git-patched.tar.gz

PET:
http://distro.ibiblio.org/pub/linux/distributions/quirky/pet_packages-quirky/rox_filer-201012git-patched.pet


Posted on 27 Dec 2010, 11:42


Comments:

Posted on 27 Dec 2010, 23:10 by ttuuxxx
ROX-Filer
Hi Barry thanks for the patched sources, The only thing your patched sources needs is the removal of "Running as user root" from the top of window, It used to be easy to remove this but this version is much more difficult, what do you edit or delete to make that go away, I spent about 3hrs trying all different things and still getting that message.

Thanks
ttuuxxx


Posted on 28 Dec 2010, 6:40 by BarryK
Rox: running as root
I did remove that message in my patched source.

These are the two patches I applied:

Edit ROX-Filer/src/menu.c:

change "Send To..." string to "Open With..."

Edit ROX-Filer/src/main.c, commented out this line:
if (euid == 0 || show_user) show_user_message = g_strdup_printf(_("Running as user '%s'"), user_name(euid));




Posted on 28 Dec 2010, 7:08 by ttuuxxx
ROX-Filer
Hi Barry your right you did, Before I think I used to just open a new window with rox and that window would show the root message removed, But this time only after I restarted X server was it finally gone, anyways all is good now and sorry I was mistaken.
ttuuxxx


Posted on 28 Dec 2010, 14:55 by technosaurus
re: rox as root
it is sufficient to just remove
euid == 0 ||

//leave showuser otherwise you break the user message option
//& _should_ probably remove the usage text:
-u, --user show user name in each window


Posted on 28 Dec 2010, 15:17 by 01micko
re rox
Is it enough to flip the switch from 0 to 1? That's what I did and it worked, no message, been using it a couple of days, no problems.


Posted on 29 Dec 2010, 2:30 by technosaurus
re rox
As configured, yes... unless you add an admin account with a uid of 1. Otherwise it is just pointless code that shouldn't hurt anything short of an extra nanosecond of startup time.


Posted on 4 Mar 2011, 9:36 by BarryK
ROX bug links

http://murga-linux.com/puppy/viewtopic.php?p=500716#500716