ROX-Filer squashed log-window

Iguleder reported about a problem with a squashed log-window and a patch that he had created:
http://bkhome.org/blog/?viewDetailed=02849

The patch is here:
http://repo.or.cz/w/rox-filer.git/patch/37a0c90d8a7e69cedf94cee6e84eafd945ffd02f

I have applied the patch and created a new PET (377KB):
http://distro.ibiblio.org/quirky/pet_packages-common/rox_filer-20111022-patched3-w5c.pet

The new source package is 'rox-filer-20111022-patched3.tar.gz', it is patched with 'rox-filer-iguleder-20120526.patch', both uploaded to my sources repo:
http://bkhome.org/sources/alphabetical/r/


Posted on 30 May 2012, 16:35


Comments:

Posted on 30 May 2012, 19:33 by Dougal
Fix Upstream
Barry, this patch was merged upstream a week or two ago, so just get a new snapshot...


Posted on 30 May 2012, 20:39 by K Godt
ROX - GTK
Cannot say it is a bug but probably disturbing for new puppians. Actually can't remamber if i ever have used the logviewer .

Now that i look at it i think it is a nice feature but would think, not beeing able to copy'n'paste from it is "kinda bug" because there is no "Save Log to File Button" .

I am using ROX-Filer 2.10, because i had too many times hangs in /proc directory wit 2.11


Posted on 31 May 2012, 9:48 by BarryK
Re rox latest
Dougal,
No, there is a problem, my rox source has a couple of patches that are not in the official source. I think that I reported on those patches in this blog, and they are in my sources repo.

I don't think that there have been any other (significant) commits to the source since I got it anyway.

Plus, my manual patches.

So, there was no need to get latest official source. If rox official source does have future improvements, then will have to revisit this situation.



Posted on 32 May 2012, 4:59 by Iguleder1
Snapshot
I agree with Dougal - it's a good time for a new ROX-Filer snapshot.

The master branch has some fixes following the 2.11 release, including translations and the patch I made - I sent it to Thomas Leonard via e-mail.


Posted on 32 May 2012, 6:58 by technosaurus
rox gtkbuilder - eliminate libglade
The one major advantage to updating rox would be the ability to drop libglade, almost everything else using it has been replaced already.


Posted on 1 Jun 2012, 8:05 by disciple
eliminate libglade - need to hack gtkdialog
Presumably gtkdialog in Puppy is still linked to libglade.
But it is easy to hack the glade support out, and I've never seen a glade based gtkdialog program in the wild.


Posted on 1 Jun 2012, 10:12 by BarryK
Re ROX from git
You guys are a bit confused, you are not properly reading what I have written. The ROX-Filer source I am using was from git on 2011-10-22. There have only been a few minor official trunk patches since then, and I do have the gtkbuilder based source.

I have applied a couple of patches developed by Puppy guys to that source, and also now Iguleder's patch.

So, there is no immediate need to get latest git snapshot.